BIND 10 trac2786, updated. ee886b45eb503cf048abf8416ce7b37430f6fb25 [2786] Always validate the contents of the buffer when provided.

[BIND 10 source code commits]

The branch, trac2786 has been updated
       via  ee886b45eb503cf048abf8416ce7b37430f6fb25 (commit)
      from  a79234992101f76634568d1128e51655ab45b42a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ee886b45eb503cf048abf8416ce7b37430f6fb25
Author: Marcin Siodelski <marcin at isc.org>
Date:   Thu May 16 10:28:19 2013 +0200

    [2786] Always validate the contents of the buffer when provided.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp/option_custom.cc |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/option_custom.cc b/src/lib/dhcp/option_custom.cc
index e807928..ee59096 100644
--- a/src/lib/dhcp/option_custom.cc
+++ b/src/lib/dhcp/option_custom.cc
@@ -32,17 +32,7 @@ OptionCustom::OptionCustom(const OptionDefinition& def,
                              const OptionBuffer& data)
     : Option(u, def.getCode(), data.begin(), data.end()),
       definition_(def) {
-    // It is possible that no data is provided if an option
-    // is being created on a server side. In such case a bunch
-    // of buffers with default values is first created and then
-    // the values are replaced using writeXXX functions. Thus
-    // we need to detect that no data has been specified and
-    // take a different code path.
-    if (!data_.empty()) {
-        createBuffers(data_);
-    } else {
-        createBuffers();
-    }
+    createBuffers(data_);
 }
 
 OptionCustom::OptionCustom(const OptionDefinition& def,