BIND 10 trac2522, updated. ea07789d058ca92c5617c2aca304fb8ad8c69c18 [2522] avoid initializing std::string at a namescope level to avoid fiasco.
BIND 10 source code commits
bind10-changes at lists.isc.org
Sat May 18 00:39:20 UTC 2013
The branch, trac2522 has been updated
via ea07789d058ca92c5617c2aca304fb8ad8c69c18 (commit)
from 1e1f87c3540b2f9de576a0267c694e8ff19a1db1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ea07789d058ca92c5617c2aca304fb8ad8c69c18
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Fri May 17 17:38:53 2013 -0700
[2522] avoid initializing std::string at a namescope level to avoid fiasco.
also constify one other object.
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/tests/rdata_minfo_unittest.cc | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/tests/rdata_minfo_unittest.cc b/src/lib/dns/tests/rdata_minfo_unittest.cc
index a374fea..828770c 100644
--- a/src/lib/dns/tests/rdata_minfo_unittest.cc
+++ b/src/lib/dns/tests/rdata_minfo_unittest.cc
@@ -34,14 +34,13 @@ using namespace isc::dns;
using namespace isc::dns::rdata;
namespace {
-const string too_long_label =
- "0123456789012345678901234567890123456789012345678901234567890123.";
-
class Rdata_MINFO_Test : public RdataTest {
protected:
Rdata_MINFO_Test():
minfo_txt("rmailbox.example.com. emailbox.example.com."),
minfo_txt2("root.example.com. emailbox.example.com."),
+ too_long_label("01234567890123456789012345678901234567"
+ "89012345678901234567890123."),
rdata_minfo(minfo_txt),
rdata_minfo2(minfo_txt2)
{}
@@ -85,6 +84,7 @@ protected:
const string minfo_txt;
const string minfo_txt2;
+ const string too_long_label;
const generic::MINFO rdata_minfo;
const generic::MINFO rdata_minfo2;
};
@@ -100,7 +100,7 @@ TEST_F(Rdata_MINFO_Test, createFromText) {
checkFromText_None(minfo_txt);
// origin defined for lexer constructor, but not string constructor
- Name origin("example.com");
+ const Name origin("example.com");
checkFromText_Origin("rmailbox emailbox", &origin);
// lexer constructor accepts extra text, but string constructor doesn't
More information about the bind10-changes
mailing list