BIND 10 trac2796, updated. 89b1ca9494abdcaf3ef2beec3fcb015b3328fea7 [2796] compare with a constant instead of a magic number

[BIND 10 source code commits]

The branch, trac2796 has been updated
       via  89b1ca9494abdcaf3ef2beec3fcb015b3328fea7 (commit)
       via  d3a4dc9a80f85583f71c789555deba8fae2f0381 (commit)
       via  1ad0a17cfbc48bec8620958e3495720355b34f81 (commit)
      from  367da9bd6d92f7fcef7505bf8c54b1a702146eef (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 89b1ca9494abdcaf3ef2beec3fcb015b3328fea7
Author: Yoshitaka Aharen <aharen at jprs.co.jp>
Date:   Wed May 29 13:48:44 2013 +0900

    [2796] compare with a constant instead of a magic number

commit d3a4dc9a80f85583f71c789555deba8fae2f0381
Author: Yoshitaka Aharen <aharen at jprs.co.jp>
Date:   Wed May 29 13:20:25 2013 +0900

    [2796] correct doxygen comment

commit 1ad0a17cfbc48bec8620958e3495720355b34f81
Author: Yoshitaka Aharen <aharen at jprs.co.jp>
Date:   Wed May 29 13:17:04 2013 +0900

    [2796] explain the meaning of the counter item in ChangeLog

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                      |    2 ++
 src/bin/auth/statistics.cc.pre |    2 +-
 src/bin/auth/statistics.h      |    3 +--
 3 files changed, 4 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/ChangeLog b/ChangeLog
index b71851e..6156840 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 TBD.	[func]		y-aharen
 	b10-auth: A new statistics item 'qryrecursion' has been introduced.
+	The counter is for the number of queries (OpCode=Query) with Recursion
+	Desired (RD) bit on.
 	(Trac #2796, git TBD)
 
 614.	[func]		tmark
diff --git a/src/bin/auth/statistics.cc.pre b/src/bin/auth/statistics.cc.pre
index 6caca00..ec39db6 100644
--- a/src/bin/auth/statistics.cc.pre
+++ b/src/bin/auth/statistics.cc.pre
@@ -142,7 +142,7 @@ Counters::incRequest(const MessageAttributes& msgattrs) {
         server_msg_counter_.inc(opcode_to_msgcounter[code]);
 
         // Opcode = 0: Query
-        if (code == 0) {
+        if (code == Opcode::QUERY_CODE) {
             // Recursion Desired bit
             if (msgattrs.requestHasRD()) {
                 server_msg_counter_.inc(MSG_QRYRECURSION);
diff --git a/src/bin/auth/statistics.h b/src/bin/auth/statistics.h
index 9fe2c4e..2ab987d 100644
--- a/src/bin/auth/statistics.h
+++ b/src/bin/auth/statistics.h
@@ -182,8 +182,7 @@ public:
 
     /// \brief Set Recursion Desired (RD) bit of the request.
     ///
-    /// \param with_dnssec_ok true if Recursion Desired (RD)bit of the request
-    //                        is set
+    /// \param with_rd true if Recursion Desired (RD)bit of the request is set
     /// \throw None
     void setRequestRD(const bool with_rd) {
         bit_attributes_[REQ_WITH_RD] = with_rd;