BIND 10 trac3184, updated. 77c44b84587d190af775c8ab1d06e77857544d75 [3184] Comments updated.

[BIND 10 source code commits]

The branch, trac3184 has been updated
       via  77c44b84587d190af775c8ab1d06e77857544d75 (commit)
      from  62e07f67a8f462d7e7a1f446376cea3650827973 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 77c44b84587d190af775c8ab1d06e77857544d75
Author: Tomek Mrugalski <tomasz at isc.org>
Date:   Thu Oct 10 19:40:56 2013 +0200

    [3184] Comments updated.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/dhcp4/tests/dhcp4_test_utils.h |   13 ++++++++++++-
 src/bin/dhcp4/tests/wireshark.cc       |    4 ++++
 2 files changed, 16 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/bin/dhcp4/tests/dhcp4_test_utils.h b/src/bin/dhcp4/tests/dhcp4_test_utils.h
index b8ed485..b02e4ce 100644
--- a/src/bin/dhcp4/tests/dhcp4_test_utils.h
+++ b/src/bin/dhcp4/tests/dhcp4_test_utils.h
@@ -39,12 +39,13 @@ public:
     /// Also sets up initial configuration in CfgMgr.
     Dhcpv4SrvTest();
 
+    /// @brief destructor
     virtual ~Dhcpv4SrvTest() {
     }
 
     /// @brief Add 'Parameter Request List' option to the packet.
     ///
-    /// This function PRL option comprising the following option codes:
+    /// This function adds PRL option comprising the following option codes:
     /// - 5 - Name Server
     /// - 15 - Domain Name
     /// - 7 - Log Server
@@ -129,8 +130,18 @@ public:
     /// @param expected_clientid expected value of client-id
     void checkClientId(const Pkt4Ptr& rsp, const OptionPtr& expected_clientid);
 
+    /// @brief sets default fields in a captured packet
+    ///
+    /// Sets UDP ports, addresses and interface.
+    ///
+    /// @param pkt packet to have default fields set
     void captureSetDefaultFields(const Pkt4Ptr& pkt);
 
+    /// @brief returns captured DISCOVER that went through a relay
+    ///
+    /// See method code for a detailed explanation.
+    ///
+    /// @return relayed DISCOVER
     Pkt4Ptr captureRelayedDiscover();
 
     /// @brief Tests if Discover or Request message is processed correctly
diff --git a/src/bin/dhcp4/tests/wireshark.cc b/src/bin/dhcp4/tests/wireshark.cc
index 90bf074..a338c37 100644
--- a/src/bin/dhcp4/tests/wireshark.cc
+++ b/src/bin/dhcp4/tests/wireshark.cc
@@ -35,6 +35,10 @@
 /// 6. Coding guidelines line restrictions apply, so wrap your code as necessary
 /// 7. Make sure you decribe the capture appropriately
 /// 8. Follow whatever rest of the methods are doing (set ports, ifaces etc.)
+/// 9. To easily copy packet description, click File... -> Extract packet
+///    dissections -> as plain text file...
+///    (Make sure that the packet is expanded in the view. The text file will
+///    contain whatever expansion level you have in the graphical tree.)
 
 using namespace std;
 using namespace isc::asiolink;