BIND 10 trac3073, updated. e7fff7124061a6fb64dfb03d3e652de8b883305c [3073] Rremove incorrect checks for empty() that caused test failures
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Oct 22 10:24:44 UTC 2013
The branch, trac3073 has been updated
via e7fff7124061a6fb64dfb03d3e652de8b883305c (commit)
via d1397da715c4c2fd9039923250f380e3f1172fb3 (commit)
from 2d83a3a525c255b565aa57e3bd5efce5ca38a269 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e7fff7124061a6fb64dfb03d3e652de8b883305c
Author: Kean Johnston <kean at isc.org>
Date: Tue Oct 22 12:03:59 2013 +0200
[3073] Rremove incorrect checks for empty() that caused test failures
commit d1397da715c4c2fd9039923250f380e3f1172fb3
Author: Kean Johnston <kean at isc.org>
Date: Tue Oct 22 12:00:12 2013 +0200
[3073] Rremove incorrect checks for empty() that caused test failures
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/cache_config.cc | 4 ----
src/lib/datasrc/client_list.cc | 4 ----
src/lib/server_common/portconfig.cc | 3 +--
3 files changed, 1 insertion(+), 10 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/cache_config.cc b/src/lib/datasrc/cache_config.cc
index 86c0125..ec3cfeb 100644
--- a/src/lib/datasrc/cache_config.cc
+++ b/src/lib/datasrc/cache_config.cc
@@ -106,10 +106,6 @@ CacheConfig::CacheConfig(const std::string& datasrc_type,
}
const ConstElementPtr zones = datasrc_conf.get("cache-zones");
- if (zones->empty()) {
- return;
- }
-
for (size_t i = 0; i < zones->size(); ++i) {
const dns::Name zone_name(zones->get(i)->stringValue());
if (!zone_config_.insert(Zones::value_type(zone_name,
diff --git a/src/lib/datasrc/client_list.cc b/src/lib/datasrc/client_list.cc
index aaa5a6f..94afe96 100644
--- a/src/lib/datasrc/client_list.cc
+++ b/src/lib/datasrc/client_list.cc
@@ -84,10 +84,6 @@ ConfigurableClientList::configure(const ConstElementPtr& config,
isc_throw(isc::BadValue, "NULL configuration passed");
}
- if (config->empty()) {
- return;
- }
-
// TODO: Implement recycling from the old configuration.
size_t i(0); // Outside of the try to be able to access it in the catch
try {
diff --git a/src/lib/server_common/portconfig.cc b/src/lib/server_common/portconfig.cc
index 4c47cc0..6120c7d 100644
--- a/src/lib/server_common/portconfig.cc
+++ b/src/lib/server_common/portconfig.cc
@@ -37,8 +37,7 @@ parseAddresses(isc::data::ConstElementPtr addresses,
{
AddressList result;
if (addresses) {
- if (addresses->getType() == Element::list &&
- !addresses->empty() ) {
+ if (addresses->getType() == Element::list) {
for (size_t i(0); i < addresses->size(); ++ i) {
ConstElementPtr addrPair(addresses->get(i));
ConstElementPtr addr(addrPair->get("address"));
More information about the bind10-changes
mailing list