BIND 10 trac3086, updated. 351b73dcc7a084622b91868cbab14ad2b2d93469 [3086] Added todo comment regarding default constructor use.
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Sep 6 14:18:20 UTC 2013
The branch, trac3086 has been updated
via 351b73dcc7a084622b91868cbab14ad2b2d93469 (commit)
from 92adc1fb42e8966816f96b4e6521bd2a18cead1f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 351b73dcc7a084622b91868cbab14ad2b2d93469
Author: Thomas Markwalder <tmark at isc.org>
Date: Fri Sep 6 10:17:24 2013 -0400
[3086] Added todo comment regarding default constructor use.
-----------------------------------------------------------------------
Summary of changes:
src/lib/dhcp_ddns/ncr_msg.h | 8 ++++++++
1 file changed, 8 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/lib/dhcp_ddns/ncr_msg.h b/src/lib/dhcp_ddns/ncr_msg.h
index ceb8715..48cd9b1 100644
--- a/src/lib/dhcp_ddns/ncr_msg.h
+++ b/src/lib/dhcp_ddns/ncr_msg.h
@@ -156,6 +156,14 @@ typedef std::map<std::string, isc::data::ConstElementPtr> ElementMap;
class NameChangeRequest {
public:
/// @brief Default Constructor.
+ ///
+ /// @todo Currently, fromWire makes use of the ability to create an empty
+ /// NameChangeRequest and then builds it bit by bit. This means that it
+ /// is technically possible to create one and attempt to use in ways
+ /// other than intended and its invalid content may or may not be handled
+ /// gracefully by consuming code. It might be wise to revisit this
+ /// structuring such that we do not use a default constructor and only
+ /// allow valid instantiations.
NameChangeRequest();
/// @brief Constructor. Full constructor, which provides parameters for
More information about the bind10-changes
mailing list