BIND 10 trac2512, updated. 11052a822a6c329a087e5590ac525ab3107926a8 [2512] Fix indent level

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Feb 6 12:17:42 UTC 2014


The branch, trac2512 has been updated
       via  11052a822a6c329a087e5590ac525ab3107926a8 (commit)
       via  969a916daeffe16ba2c04f3f1eead285284b3162 (commit)
       via  e48ae4647c1dfbc827d3e4538e9f35dd1d3c96f9 (commit)
      from  2e80ea0623fc05edc4f6088b024f9ea3cd168dff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 11052a822a6c329a087e5590ac525ab3107926a8
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Feb 6 17:47:18 2014 +0530

    [2512] Fix indent level

commit 969a916daeffe16ba2c04f3f1eead285284b3162
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Feb 6 17:46:24 2014 +0530

    [2512] Add a comment about redundant test

commit e48ae4647c1dfbc827d3e4538e9f35dd1d3c96f9
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Feb 6 17:44:22 2014 +0530

    [2512] Add equality test in .compare unittest

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/tests/rdata_caa_unittest.cc |   16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/tests/rdata_caa_unittest.cc b/src/lib/dns/tests/rdata_caa_unittest.cc
index afa1c3c..579cba9 100644
--- a/src/lib/dns/tests/rdata_caa_unittest.cc
+++ b/src/lib/dns/tests/rdata_caa_unittest.cc
@@ -38,10 +38,10 @@ using namespace isc::dns::rdata;
 namespace {
 class Rdata_CAA_Test : public RdataTest {
 protected:
-        Rdata_CAA_Test() :
-            caa_txt("0 issue \"ca.example.net\""),
-            rdata_caa(caa_txt)
-        {}
+    Rdata_CAA_Test() :
+        caa_txt("0 issue \"ca.example.net\""),
+        rdata_caa(caa_txt)
+    {}
 
     void checkFromText_None(const string& rdata_str) {
         checkFromText<generic::CAA, isc::Exception, isc::Exception>(
@@ -116,7 +116,8 @@ TEST_F(Rdata_CAA_Test, fields) {
     EXPECT_NO_THROW(const generic::CAA rdata_caa2("0 relaxed-too \"ca.example.net\""));
     EXPECT_NO_THROW(const generic::CAA rdata_caa2("0 RELAXED.too \"ca.example.net\""));
 
-    // No value
+    // No value (this is redundant to the last test case in the
+    // .createFromText test
     EXPECT_NO_THROW(const generic::CAA rdata_caa2("0 issue"));
 
     // > 255 would be broken
@@ -229,6 +230,11 @@ TEST_F(Rdata_CAA_Test, toWire) {
 }
 
 TEST_F(Rdata_CAA_Test, compare) {
+    // Equality test is repeated from createFromWire tests above.
+    EXPECT_EQ(0, rdata_caa.compare(
+                  *rdataFactoryFromFile(RRType("CAA"), RRClass("IN"),
+                                        "rdata_caa_fromWire1.wire")));
+
     const generic::CAA rdata_caa2("1 issue \"ca.example.net\"");
 
     EXPECT_EQ(1, rdata_caa2.compare(rdata_caa));



More information about the bind10-changes mailing list