BIND 10 master, updated. 0053becdd7452871439bcc19095ed9b50f7e01bc [master] Corrected dhcp_ddns::WatchSocket unit test failure

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Feb 11 18:43:06 UTC 2014


The branch, master has been updated
       via  0053becdd7452871439bcc19095ed9b50f7e01bc (commit)
      from  9bcad85c5805dd4997d59bf15646aa18ceaf3d20 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0053becdd7452871439bcc19095ed9b50f7e01bc
Author: Thomas Markwalder <tmark at isc.org>
Date:   Tue Feb 11 13:40:57 2014 -0500

    [master] Corrected dhcp_ddns::WatchSocket unit test failure
    
    Unit test was failing as a closed fd passed to select() does not fail
    on all OSs.  Changed the test so it verifies that the fd in question
    no longer evaluates to ready to ready.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp_ddns/tests/watch_socket_unittests.cc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp_ddns/tests/watch_socket_unittests.cc b/src/lib/dhcp_ddns/tests/watch_socket_unittests.cc
index 82999f6..e19b8cb 100644
--- a/src/lib/dhcp_ddns/tests/watch_socket_unittests.cc
+++ b/src/lib/dhcp_ddns/tests/watch_socket_unittests.cc
@@ -194,8 +194,8 @@ TEST(WatchSocketTest, badReadOnClear) {
     /// @todo maybe clear should never throw, log only
     ASSERT_THROW(watch->clearReady(), WatchSocketError);
 
-    // Verify the select_fd fails as socket is invalid/closed.
-    EXPECT_EQ(-1, selectCheck(select_fd));
+    // Verify the select_fd does not evalute to ready.
+    EXPECT_NE(1, selectCheck(select_fd));
 
     // Verify that getSelectFd() returns INVALID.
     ASSERT_EQ(WatchSocket::INVALID_SOCKET, watch->getSelectFd());



More information about the bind10-changes mailing list