BIND 10 trac3207, updated. 94be309810fb7f5964fa52c8348a12e100bd0428 [3207] A few more minor review changes.

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Jan 2 17:15:20 UTC 2014


The branch, trac3207 has been updated
       via  94be309810fb7f5964fa52c8348a12e100bd0428 (commit)
      from  b425b35008aa702182f722dc34e8fffc27f19270 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 94be309810fb7f5964fa52c8348a12e100bd0428
Author: Thomas Markwalder <tmark at isc.org>
Date:   Thu Jan 2 12:13:34 2014 -0500

    [3207] A few more minor review changes.
    
    Removed reponse packet type check from IPv6 packet_snd callout.
    Corrected text in user chk doxygen page.

-----------------------------------------------------------------------

Summary of changes:
 src/hooks/dhcp/user_chk/libdhcp_user_chk.dox |    4 ++--
 src/hooks/dhcp/user_chk/pkt_send_co.cc       |    9 ---------
 2 files changed, 2 insertions(+), 11 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox b/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox
index b2592d4..09d0e48 100644
--- a/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox
+++ b/src/hooks/dhcp/user_chk/libdhcp_user_chk.dox
@@ -101,9 +101,9 @@ following two entries:
 
     - "type" whose value is "HW_ADDR" for IPv4 users or "DUID" for IPv6 users
     - "id" whose value is either the hardware address or the DUID from the
-    request formatted as a sring of hex digits, with or without ":" delimiters.
+    request formatted as a string of hex digits, with or without ":" delimiters.
 
-and may have the one or more of the following entries:
+and may have the zero or more of the following entries:
 
     - "bootfile" whose value is the pathname of the desired file
     - "tftp_server" whose value is the hostname or IP address of the desired
diff --git a/src/hooks/dhcp/user_chk/pkt_send_co.cc b/src/hooks/dhcp/user_chk/pkt_send_co.cc
index e13ea1b..805333b 100644
--- a/src/hooks/dhcp/user_chk/pkt_send_co.cc
+++ b/src/hooks/dhcp/user_chk/pkt_send_co.cc
@@ -149,15 +149,6 @@ int pkt6_send(CalloutHandle& handle) {
         Pkt6Ptr response;
         handle.getArgument("response6", response);
 
-        // @todo Determine list of types to process and skip the rest.
-        uint8_t packet_type = response->getType();
-        if (packet_type == DHCPV6_DECLINE) {
-            std::cout << "DHCP UserCheckHook : pkt6_send"
-                      << "skipping packet type: "
-                      << static_cast<int>(packet_type) << std::endl;
-            return (0);
-        }
-
         // Fetch the lease address as a string
         std::string addr_str = getV6AddrStr(response);
         if (addr_str.empty()) {



More information about the bind10-changes mailing list