BIND 10 trac3089, updated. 9934a46fea9632cd6ea6fd6e1409498316330223 [3089] Added ticket number to commentary
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Jan 13 18:09:52 UTC 2014
The branch, trac3089 has been updated
via 9934a46fea9632cd6ea6fd6e1409498316330223 (commit)
from 1736d2d26ee043529888649ecd536bc54f1015fb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9934a46fea9632cd6ea6fd6e1409498316330223
Author: Thomas Markwalder <tmark at isc.org>
Date: Mon Jan 13 13:08:02 2014 -0500
[3089] Added ticket number to commentary
Added todo to dns_client.cc commentary regarding
trac# 3286 and the behavior isc::dns::Message::fromWire.
-----------------------------------------------------------------------
Summary of changes:
src/bin/d2/dns_client.cc | 6 ++++--
src/bin/d2/tests/nc_test_utils.h | 4 ++++
2 files changed, 8 insertions(+), 2 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/d2/dns_client.cc b/src/bin/d2/dns_client.cc
index 00b0ff9..9202e7d 100644
--- a/src/bin/d2/dns_client.cc
+++ b/src/bin/d2/dns_client.cc
@@ -50,8 +50,10 @@ public:
// once in the lifetime of a Message instance. Therefore, response_ is a
// pointer reference thus allowing this class to replace the object
// pointed to with a new Message instance each time a message is
- // received. This allows a single DNSClientImpl instance to be used in
- // for multiple, sequential IOFetch calls.
+ // received. This allows a single DNSClientImpl instance to be used for
+ // multiple, sequential IOFetch calls. (@todo Trac# 3286 has been opened
+ // against dns::Message::fromWire. Should the behavior of fromWire change
+ // the behavior here with could be rexamined).
D2UpdateMessagePtr& response_;
// A caller-supplied external callback which is invoked when DNS message
// exchange is complete or interrupted.
diff --git a/src/bin/d2/tests/nc_test_utils.h b/src/bin/d2/tests/nc_test_utils.h
index 6292436..a997525 100644
--- a/src/bin/d2/tests/nc_test_utils.h
+++ b/src/bin/d2/tests/nc_test_utils.h
@@ -358,6 +358,10 @@ extern void addDomainServer(DdnsDomainPtr& domain, const std::string& name,
/// @brief Creates a hex text dump of the given data buffer.
///
+/// This method is not used for testing but is handy for debugging. It creates
+/// a pleasantly formatted string of 2-digits per byte separated by spaces with
+/// 16 bytes per line.
+///
/// @param data pointer to the data to dump
/// @param len size (in bytes) of data
extern std::string toHexText(const uint8_t* data, size_t len);
More information about the bind10-changes
mailing list