BIND 10 trac3264, updated. 432acd7ecbdbe741d07c20f8b43be107d9f761b2 [3264] Addressed review comments.

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jan 15 13:02:55 UTC 2014


The branch, trac3264 has been updated
       via  432acd7ecbdbe741d07c20f8b43be107d9f761b2 (commit)
      from  faf86ad3a04fc7fca0af2b9d19abba0fa1d94387 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 432acd7ecbdbe741d07c20f8b43be107d9f761b2
Author: Thomas Markwalder <tmark at isc.org>
Date:   Wed Jan 15 08:01:58 2014 -0500

    [3264] Addressed review comments.
    
    Added missing test method commentary.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/d2/tests/nc_trans_unittests.cc |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/d2/tests/nc_trans_unittests.cc b/src/bin/d2/tests/nc_trans_unittests.cc
index 7a8110d..7045dfb 100644
--- a/src/bin/d2/tests/nc_trans_unittests.cc
+++ b/src/bin/d2/tests/nc_trans_unittests.cc
@@ -297,6 +297,11 @@ public:
                                   forward_domain_, reverse_domain_)));
     }
 
+    /// @brief Builds and then sends an update request
+    ///
+    /// This method is used to build and send and update request. It is used
+    /// in conjuction with FauxServer to test various message response
+    /// scenarios.
     void doOneExchange(NameChangeStubPtr name_change,
                        unsigned int run_time = 500) {
         // Create a valid request for the transaction.
@@ -852,8 +857,8 @@ TEST_F(NameChangeTransactionTest, sendUpdateTimeout) {
     // Note we have to wait for DNSClient timeout plus a bit more to allow
     // DNSClient to timeout.
     ASSERT_NO_FATAL_FAILURE(doOneExchange(name_change,
-                             NameChangeTransaction::DNS_UPDATE_DEFAULT_TIMEOUT
-                             + 100));
+                                          NameChangeTransaction::
+                                          DNS_UPDATE_DEFAULT_TIMEOUT + 100));
 
     // Verify that next event is IO_COMPLETED_EVT and DNS status is TIMEOUT.
     ASSERT_EQ(NameChangeTransaction::IO_COMPLETED_EVT,



More information about the bind10-changes mailing list