BIND 10 master, updated. 5a2b69ed6fcb4f4ff2589f679716cb9436116232 [master] Corrected intermittent D2 unit test failure

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jan 15 21:01:18 UTC 2014


The branch, master has been updated
       via  5a2b69ed6fcb4f4ff2589f679716cb9436116232 (commit)
      from  a66dc23ea5d6c6ecd34d9598d7e111d1c0ce696d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5a2b69ed6fcb4f4ff2589f679716cb9436116232
Author: Thomas Markwalder <tmark at isc.org>
Date:   Wed Jan 15 15:59:10 2014 -0500

    [master] Corrected intermittent D2 unit test failure
    
    On sluggish machines D2UpdateMgrTest.multiTransactionTimeout
    failed intermittantly. A run-away test check was a bit too
    stringent.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/d2/tests/d2_update_mgr_unittests.cc |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/d2/tests/d2_update_mgr_unittests.cc b/src/bin/d2/tests/d2_update_mgr_unittests.cc
index c97b744..2711a71 100644
--- a/src/bin/d2/tests/d2_update_mgr_unittests.cc
+++ b/src/bin/d2/tests/d2_update_mgr_unittests.cc
@@ -213,7 +213,7 @@ public:
     /// vary.
     void processAll(unsigned int timeout_millisec =
                     NameChangeTransaction::DNS_UPDATE_DEFAULT_TIMEOUT + 100,
-                    size_t max_passes = 20) {
+                    size_t max_passes = 100) {
         // Loop until all the transactions have been dequeued and run through to
         // completion.
         size_t passes = 0;
@@ -238,9 +238,9 @@ public:
             }
 
             // This is a last resort fail safe to ensure we don't go around
-            // forever. We cut it off the number of passes at 20.  This is
-            // roughly twice the number for the longest test (currently,
-            // multiTransactionTimeout).
+            // forever. We cut it off the number of passes at 100 (default
+            // value).  This is roughly ten times the number for the longest
+            // test (currently, multiTransactionTimeout).
             if (passes > max_passes) {
                 ADD_FAILURE() << "processALL failed, too many passes: "
                     << passes <<  ", total handlers executed: " << handlers;



More information about the bind10-changes mailing list