BIND 10 trac1397, updated. 30c527eedf5ff9b38d20f81c795acfb049c7aed9 [1397] Add missing TreeNodeRRset::addRdata() implementation for new interface
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Jan 29 13:26:24 UTC 2014
The branch, trac1397 has been updated
via 30c527eedf5ff9b38d20f81c795acfb049c7aed9 (commit)
from 6db6928823e9f7626c3d49f4583f665d92e8ee95 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 30c527eedf5ff9b38d20f81c795acfb049c7aed9
Author: Mukund Sivaraman <muks at isc.org>
Date: Wed Jan 29 18:47:51 2014 +0530
[1397] Add missing TreeNodeRRset::addRdata() implementation for new interface
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/memory/treenode_rrset.cc | 5 +++++
src/lib/datasrc/memory/treenode_rrset.h | 5 +++++
.../tests/memory/treenode_rrset_unittest.cc | 1 +
3 files changed, 11 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/treenode_rrset.cc b/src/lib/datasrc/memory/treenode_rrset.cc
index 4734e04..5b5b088 100644
--- a/src/lib/datasrc/memory/treenode_rrset.cc
+++ b/src/lib/datasrc/memory/treenode_rrset.cc
@@ -195,6 +195,11 @@ TreeNodeRRset::addRdata(const rdata::Rdata&) {
isc_throw(Unexpected, "unexpected method called on TreeNodeRRset");
}
+void
+TreeNodeRRset::addRdata(const std::string&) {
+ isc_throw(Unexpected, "unexpected method called on TreeNodeRRset");
+}
+
namespace {
// In this namespace we define a set of helper stuff to implement the
// RdataIterator for the TreeNodeRRset. We should eventually optimize
diff --git a/src/lib/datasrc/memory/treenode_rrset.h b/src/lib/datasrc/memory/treenode_rrset.h
index 640c972..062a5b5 100644
--- a/src/lib/datasrc/memory/treenode_rrset.h
+++ b/src/lib/datasrc/memory/treenode_rrset.h
@@ -204,6 +204,11 @@ public:
/// It throws \c isc::Unexpected unconditionally.
virtual void addRdata(const dns::rdata::Rdata& rdata);
+ /// \brief Specialized version of \c addRdata() for \c TreeNodeRRset.
+ ///
+ /// It throws \c isc::Unexpected unconditionally.
+ virtual void addRdata(const std::string& rdata_str);
+
virtual dns::RdataIteratorPtr getRdataIterator() const;
/// \brief Specialized version of \c getRRsig() for \c TreeNodeRRset.
diff --git a/src/lib/datasrc/tests/memory/treenode_rrset_unittest.cc b/src/lib/datasrc/tests/memory/treenode_rrset_unittest.cc
index 4d1f6e1..358006d 100644
--- a/src/lib/datasrc/tests/memory/treenode_rrset_unittest.cc
+++ b/src/lib/datasrc/tests/memory/treenode_rrset_unittest.cc
@@ -663,6 +663,7 @@ TEST_F(TreeNodeRRsetTest, unexpectedMethods) {
EXPECT_THROW(rrset.setTTL(RRTTL(0)), isc::Unexpected);
EXPECT_THROW(rrset.addRdata(createRdata(RRType::A(), rrclass_, "0.0.0.0")),
isc::Unexpected);
+ EXPECT_THROW(rrset.addRdata("0.0.0.0"), isc::Unexpected);
RdataPtr sig_rdata = createRdata(
RRType::RRSIG(), rrclass_,
"A 5 2 3600 20120814220826 20120715220826 5300 example.com. FAKE");
More information about the bind10-changes
mailing list