BIND 10 trac3312, updated. 6f07eddae79a4d7afae38bbd514054a26c8da5e1 [3312] Remove redundant variable (cppcheck report)

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jan 29 16:57:08 UTC 2014


The branch, trac3312 has been updated
       via  6f07eddae79a4d7afae38bbd514054a26c8da5e1 (commit)
       via  5c806a27410b36452daa82dace047579cf42d3c2 (commit)
      from  bbee45a49834b3e89a9afaf05acd98f1b6b3b76e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6f07eddae79a4d7afae38bbd514054a26c8da5e1
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jan 29 22:26:46 2014 +0530

    [3312] Remove redundant variable (cppcheck report)

commit 5c806a27410b36452daa82dace047579cf42d3c2
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jan 29 22:22:42 2014 +0530

    [3312] Avoid C++ language parser warning of uninitialized variable

-----------------------------------------------------------------------

Summary of changes:
 src/lib/acl/ip_check.cc                           |    2 +-
 src/lib/resolve/tests/recursive_query_unittest.cc |    2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/acl/ip_check.cc b/src/lib/acl/ip_check.cc
index 7192064..c1f590f 100644
--- a/src/lib/acl/ip_check.cc
+++ b/src/lib/acl/ip_check.cc
@@ -115,7 +115,7 @@ namespace {
 const uint8_t*
 getSockAddrData(const struct sockaddr& sa) {
     const void* sa_ptr = &sa;
-    const void* data_ptr;
+    const void* data_ptr = NULL;
     if (sa.sa_family == AF_INET) {
         const struct sockaddr_in* sin =
             static_cast<const struct sockaddr_in*>(sa_ptr);
diff --git a/src/lib/resolve/tests/recursive_query_unittest.cc b/src/lib/resolve/tests/recursive_query_unittest.cc
index 48e5a31..df4b9d4 100644
--- a/src/lib/resolve/tests/recursive_query_unittest.cc
+++ b/src/lib/resolve/tests/recursive_query_unittest.cc
@@ -377,7 +377,6 @@ protected:
                             DNSLookup* lookup = NULL,
                             DNSAnswer* answer = NULL) :
             io_(io_service),
-            done_(false),
             message_(new Message(Message::PARSE)),
             answer_message_(new Message(Message::RENDER)),
             respbuf_(new OutputBuffer(0)),
@@ -406,7 +405,6 @@ protected:
 
     protected:
         IOService& io_;
-        bool done_;
 
     private:
         // Currently unused; these will be used for testing



More information about the bind10-changes mailing list