BIND 10 trac3358, updated. 7b3fc03b8738888519a54f9286ec4c2ba7d33521 [3358] Addressed review comments

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Mar 11 13:47:09 UTC 2014


The branch, trac3358 has been updated
       via  7b3fc03b8738888519a54f9286ec4c2ba7d33521 (commit)
      from  72f017e69f32c908212ff91d8305b32cd9dcff45 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7b3fc03b8738888519a54f9286ec4c2ba7d33521
Author: Thomas Markwalder <tmark at isc.org>
Date:   Tue Mar 11 09:45:48 2014 -0400

    [3358] Addressed review comments
    
    Fixed getFullCommentary so is_default is marked as an out parameter.
    Fixed Makefile.am to account for new test spec file.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/config/config_data.h              |   19 +++++++++----------
 src/lib/config/tests/testdata/Makefile.am |    1 +
 2 files changed, 10 insertions(+), 10 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/config/config_data.h b/src/lib/config/config_data.h
index 8ca7226..a742f48 100644
--- a/src/lib/config/config_data.h
+++ b/src/lib/config/config_data.h
@@ -72,7 +72,7 @@ public:
     /// .spec file) is returned. If there is no value and no default,
     /// an empty ElementPtr is returned.
     /// Raises a DataNotFoundError if the identifier is bad.
-    /// \param is_default will be set to true if the value is taken
+    /// \param [out] is_default will be set to true if the value is taken
     ///                   from the specifications item_default setting,
     ///                   false otherwise
     /// \param identifier The identifier pointing to the configuration
@@ -81,19 +81,18 @@ public:
                                         const std::string& identifier) const;
 
     /// Returns the "full" value for the given identifier
-    /// If the item referredt toyidentifier is not a map item, then it simply
-    /// returns the value yielded by getValue() .  If the identifier
-    /// refers to a map item, then it returns a merged map of the map
-    /// items' defaults and configured values.
-    /// The default values for the items in the map are taken from the
-    /// map's default value if not empty (i.e. not "{}").  If the map defualt
-    /// is empty, then the item default values are taken from each item spec
-    /// within the map spec.
+    /// If the item referred to by identifier is not a map item, then it simply
+    /// returns the value yielded by getValue() .  If the identifier refers to
+    /// a map item, then it returns a merged map of the map items' defaults
+    /// and its configured values.  The default values for the items in the
+    /// map are taken from the map's default value if not empty (i.e. not "{}").
+    /// If the map defualt is empty, then the item default values are taken
+    /// from each item spec within the map spec.
     ///
     /// @todo This method should be made to recurse into maps of maps.
     ///
     /// Raises a DataNotFoundError if the identifier is bad.
-    /// \param is_default will be set to true if the value is taken
+    /// \param [out] is_default will be set to true if the value is taken
     ///                   from the specifications item_default setting,
     ///                   false otherwise
     /// \param identifier The identifier pointing to the configuration
diff --git a/src/lib/config/tests/testdata/Makefile.am b/src/lib/config/tests/testdata/Makefile.am
index 9b383d6..0e310e8 100644
--- a/src/lib/config/tests/testdata/Makefile.am
+++ b/src/lib/config/tests/testdata/Makefile.am
@@ -71,3 +71,4 @@ EXTRA_DIST += spec39.spec
 EXTRA_DIST += spec40.spec
 EXTRA_DIST += spec41.spec
 EXTRA_DIST += spec42.spec
+EXTRA_DIST += spec43.spec



More information about the bind10-changes mailing list