[bind10-dev] DNS message API: name class is ready for review

[Jeremy C. Reed]

First I needed this with gcc 4.4.1 but also worked with 4.1.3.

Index: src/lib/dns/cpp/buffer.h
===================================================================
--- src/lib/dns/cpp/buffer.h	(revision 394)
+++ src/lib/dns/cpp/buffer.h	(working copy)
@@ -19,6 +19,8 @@
 
 #include <vector>
 
+#include <cstring>	// for memcpy
+
 #include "exceptions.h"
 
 namespace isc {
Index: src/lib/dns/cpp/name.cc
===================================================================
--- src/lib/dns/cpp/name.cc	(revision 394)
+++ src/lib/dns/cpp/name.cc	(working copy)
@@ -18,6 +18,7 @@
 #include <cassert>
 #include <iterator>
 #include <functional>
+#include <algorithm>	// for transform
 
 #include "buffer.h"
 #include "name.h"


I configured with gtest. My build failed with:

Making all in cpp
/bin/ksh ../../../../libtool --tag=CXX    --mode=link g++   -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -fPIC -L/usr/pkg/lib  -o run_unittests run_unittests-unittest_util.o  run_unittests-buffer_unittest.o  run_unittests-name_unittest.o  run_unittests-messagerenderer_unittest.o  run_unittests-exceptions_unittest.o  run_unittests-run_unittests.o .libs/libdns.a -lgtest 
libtool: link: g++ -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -fPIC -o run_unittests run_unittests-unittest_util.o run_unittests-buffer_unittest.o run_unittests-name_unittest.o run_unittests-messagerenderer_unittest.o run_unittests-exceptions_unittest.o run_unittests-run_unittests.o  -L/usr/pkg/lib .libs/libdns.a /usr/pkg/lib/libgtest.so -Wl,-rpath -Wl,/usr/pkg/lib -Wl,-rpath -Wl,/usr/pkg/lib
run_unittests-name_unittest.o: In function `(anonymous namespace)::NameTest_fromText_Test::TestBody()':
name_unittest.cc:(.text+0x881d): undefined reference to `(anonymous namespace)::NameTest::MAX_LABELS'
run_unittests-name_unittest.o: In function `(anonymous namespace)::NameTest_fromWire_Test::TestBody()':
name_unittest.cc:(.text+0x9caf): undefined reference to `(anonymous namespace)::NameTest::MAX_WIRE'
name_unittest.cc:(.text+0x9fe7): undefined reference to `(anonymous namespace)::NameTest::MAX_LABELS'
*** Error code 1

Stop.
make: stopped in /home/reed/work/isc/bind10/svn/branches/jinmei-dnsmessageapi/src/lib/dns/cpp
*** Error code 1