[bind10-dev] DNS message API: the message class

[Jelte Jansen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Some initial comments; same disclaimers as yours :)

- - there are also a few portability/compilation issues; i've had to add
#include <stdint.h>
#include <string.h>
#include <netinet/in.h>
to iobuffer.h to get it to compile on my system.

These are all things that should be placed in a configure .h output file btw
(and we might even need to add our own compat implementations for nthol etc. if
we are going to use these). Should we make the effort to make a full(er) build
system right away?

- - i'm still missing one file in the repos; dnsresult.cc

- - style issue; i think we should not have 'using namespace' statements in header
files (yes, i'm guilty too, have removed the one i had today)

- - the Rdata classes had me quite confused at first; these seemed to be
containing RRs rather than rdata fields. However reading your description it
does in fact contain all rdata fields for one resource record within the RRset,
right?

Am i correct in assuming that we will be writing (possibly static) functions for
the specific rdata fields (like an int32 rdata field, or a domainname rdata
field), which will then be reused by all Rdata classes that need them?

Still, RdataClass and RdataType could be named better imo

- - personal opinion, ignore; our naming convenctions make the Rdata class names
ugly (ARdata, AAAARdata) :p

Jelte

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrMiJsACgkQ4nZCKsdOncWIVwCgwPLiWKRF0sgQIvcOHUXC8bm+
DX8An14HsWe9uzRsRK+MLyqLL8p7IIn/
=ebX9
-----END PGP SIGNATURE-----