[bind10-dev] DNS message API: the message class

[JINMEI Tatuya / 神明達哉]

At Wed, 07 Oct 2009 14:24:59 +0200,
Jelte Jansen <jelte at isc.org> wrote:

> Some initial comments; same disclaimers as yours :)

Noted:-)  thanks for the review and comments.

> - - there are also a few portability/compilation issues; i've had to add
> #include <stdint.h>
> #include <string.h>
> #include <netinet/in.h>
> to iobuffer.h to get it to compile on my system.
> 
> These are all things that should be placed in a configure .h output file btw
> (and we might even need to add our own compat implementations for nthol etc. if
> we are going to use these). Should we make the effort to make a full(er) build
> system right away?

IMO, we don't have to worry too much about portability for the
experimental code.  But I'm now thinking about starting development on
the main trunk, so I'll soon face this problem anyway.  I guess
Jeremy's buildbot helps here.

I've added the above dot-h's to iobuffer.h for convenience.

> - - i'm still missing one file in the repos; dnsresult.cc

Sorry, added it.

> - - style issue; i think we should not have 'using namespace'
> statements in header files (yes, i'm guilty too, have removed the
> one i had today)

I tend to concur, but to be sure, is this because you want to avoid
possible name conflicts when the C++ standard ever introduces a name
we're already using?

BTW: the mozilla coding style guide has a strict rule on this:

  "using namespace ...;" is only allowed in .cpp files after all
  #includes. Prefer to wrap code in "namespace ... { ... };" instead
  if possible.
  (see https://developer.mozilla.org/en/Mozilla_Coding_Style_Guide#Namespaces)

If we agree on this, we should probably add something similar to this
to http://bind10.isc.org/wiki/CodingGuidelines

I'll answer the rdata issues later.

---
JINMEI, Tatuya