[bind10-dev] [svn] commit: r1749 - in /trunk/src/lib/auth: static_datasrc.cc tests/static_unittest.cc

[JINMEI Tatuya / 神明達哉]

At Tue, 20 Apr 2010 13:58:34 -0000,
BIND 10 source code commits <bind10-changes at lists.isc.org> wrote:

> use PACKAGE_STRING (name + version) from config.h instead of hard-coded value in CH TXT version.bind replies

This is good, but...

> -    version->addRdata(generic::TXT("BIND10 0.0.0 (pre-alpha)"));
> +    //version->addRdata(generic::TXT("BIND10-devel" CONFIG_VERSION));

what the purpose of this comment-outed line?

> +    version->addRdata(generic::TXT(PACKAGE_STRING));

Also, maybe you should update the (first) XXX comment:

>          // XXX: the following values can change as release/developers change,
>          // in which case the test code must be updated accordingly.
> -        version_data.push_back("BIND10 0.0.0 (pre-alpha)");
> +        version_data.push_back(PACKAGE_STRING);

---
JINMEI, Tatuya