[bind10-dev] Trac #327 review

[Stephen Morris]

The files are listed below.  If everyone is happy with this, I'll add the message as an attachment to the Trac #327 page to indicate what has been reviewed.

Stephen

The last complete review of #372 was done by Stephen at r3292.

Looking through the subversion log for #372 since then, significant events
since r3292 that would have resulted in a number of files being changed
(in addition to the changes made as a result of working on the branch) are:

r3783: Sync with trunk
r3660: Merge #401
r3602: Merge #393
r3565: Merge #402
r3501: Sync with trunk

The files incorporated as a result of a merge we want to check - there may have
been some changes made to resolve conflicts and they may have been altered
during subsequent editing.  The files changed purely as a result of a sync
we want to avoid - they will have been altered and reviewed in other tickets.

So, to get the list of files, the following commands were issued:

svn diff -r 3292:3500 --summarize
svn diff -r 3501:3782 --summarize
svn diff -r 3783:HEAD --summarize

... and the results merged.  Removing deleted files from the list and deleting
duplicates gives 150 files.

I've split the reviews four ways: Shane, Stephen, Jelte, Likun, with roughly
35-45 files for each person, the count being set to ensure that all the changes
in one directory are reviewed by the same person (on the assumption that the
changes will be related changes).

Before doing a review, I would suggest that the log for the file be checked.
Some of the files will have come from the branches being merged, and these
have been reviewed.  The reviews were:

#393 - reviewed at r3394
#401 - reviewed at r3524
#402 - reviewed at r3554


Shane
=====
ChangeLog
configure.ac
doc/Doxyfile
Makefile.am
README
src/bin/auth/auth_srv.cc
src/bin/auth/auth_srv.h
src/bin/auth/main.cc
src/bin/auth/Makefile.am
src/bin/auth/query.cc
src/bin/auth/query.h
src/bin/auth/tests/auth_srv_unittest.cc
src/bin/auth/tests/Makefile.am
src/bin/auth/tests/mockups.h
src/bin/auth/tests/query_unittest.cc
src/bin/bind10/bind10.py.in
src/bin/bind10/bob.spec
src/bin/bind10/run_bind10.sh.in
src/bin/bind10/tests/bind10_test.py
src/bin/bindctl/bindcmd.py
src/bin/bindctl/bindctl-source.py.in
src/bin/host/host.cc
src/bin/Makefile.am
src/bin/msgq/msgq.py.in
src/bin/recurse/main.cc
src/bin/recurse/Makefile.am
src/bin/recurse/recurse.spec.pre.in
src/bin/recurse/recursor.cc
src/bin/recurse/recursor.h
src/bin/recurse/tests/Makefile.am
src/bin/recurse/tests/recursor_unittest.cc
src/bin/stats/tests/isc/util
src/bin/xfrin/b10-xfrin.xml
src/bin/xfrout/b10-xfrout.8
src/bin/xfrout/b10-xfrout.xml
src/bin/xfrout/xfrout.spec.pre.in

Stephen
=======
src/lib/asiolink/asiolink.cc
src/lib/asiolink/asiolink.h
src/lib/asiolink/internal/coroutine.h
src/lib/asiolink/internal/tcpdns.h
src/lib/asiolink/internal/udpdns.h
src/lib/asiolink/ioaddress.h
src/lib/asiolink/Makefile.am
src/lib/asiolink/tcpdns.cc
src/lib/asiolink/tests/asiolink_unittest.cc
src/lib/asiolink/tests/Makefile.am
src/lib/asiolink/tests/udpdns_unittest.cc
src/lib/asiolink/udpdns.cc
src/lib/bench/benchmark.h
src/lib/cc/session.cc
src/lib/config/config_data.cc
src/lib/config/tests/config_data_unittests.cc
src/lib/datasrc/cache.h
src/lib/datasrc/data_source.cc
src/lib/datasrc/Makefile.am
src/lib/datasrc/static_datasrc.cc
src/lib/datasrc/tests/datasrc_unittest.cc
src/lib/datasrc/tests/Makefile.am
src/lib/datasrc/tests/sqlite3_unittest.cc
src/lib/datasrc/tests/static_unittest.cc
src/lib/datasrc/tests/test_datasrc.cc
src/lib/datasrc/tests/zonetable_unittest.cc
src/lib/datasrc/zonetable.cc
src/lib/datasrc/zonetable.h
src/lib/dns/Makefile.am
src/lib/dns/python/Makefile.am
src/lib/dns/python/pydnspp.cc
src/lib/dns/python/rrset_python.cc
src/lib/dns/python/tests/Makefile.am
src/lib/dns/python/tests/tsigkey_python_test.py
src/lib/dns/python/tsigkey_python.cc

Jelte
=====
src/lib/dns/rdata/any_255
src/lib/dns/rdata/any_255/tsig_250.cc
src/lib/dns/rdata/any_255/tsig_250.h
src/lib/dns/rrclass-placeholder.h
src/lib/dns/rrset.cc
src/lib/dns/rrset.h
src/lib/dns/tests/Makefile.am
src/lib/dns/tests/message_unittest.cc
src/lib/dns/tests/rdata_tsig_unittest.cc
src/lib/dns/tests/rrsetlist_unittest.cc
src/lib/dns/tests/rrset_unittest.cc
src/lib/dns/tests/testdata/edns_toWire4.spec
src/lib/dns/tests/testdata/gen-wiredata.py.in
src/lib/dns/tests/testdata/Makefile.am
src/lib/dns/tests/testdata/rdata_tsig_fromWire1.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire2.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire3.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire4.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire5.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire6.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire7.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire8.spec
src/lib/dns/tests/testdata/rdata_tsig_fromWire9.spec
src/lib/dns/tests/testdata/rdata_tsig_toWire1.spec
src/lib/dns/tests/testdata/rdata_tsig_toWire2.spec
src/lib/dns/tests/testdata/rdata_tsig_toWire3.spec
src/lib/dns/tests/testdata/rdata_tsig_toWire4.spec
src/lib/dns/tests/testdata/rdata_tsig_toWire5.spec
src/lib/dns/tests/tsigkey_unittest.cc
src/lib/dns/tsigkey.cc
src/lib/dns/tsigkey.h
src/lib/exceptions/exceptions.h
src/lib/log
src/lib/log/dummylog.cc
src/lib/log/dummylog.h
src/lib/log/Makefile.am
src/lib/Makefile.am


Likun
=====
src/lib/python/isc/cc/data.py
src/lib/python/isc/cc/tests/data_test.py
src/lib/python/isc/config/ccsession.py
src/lib/python/isc/config/config_data.py
src/lib/python/isc/config/tests/ccsession_test.py
src/lib/python/isc/config/tests/config_data_test.py
src/lib/python/isc/datasrc/Makefile.am
src/lib/python/isc/datasrc/master.py
src/lib/python/isc/datasrc/tests
src/lib/python/isc/datasrc/tests/Makefile.am
src/lib/python/isc/datasrc/tests/master_test.py
src/lib/python/isc/notify/notify_out.py
src/lib/python/isc/notify/tests/notify_out_test.py
src/lib/python/isc/util
src/lib/python/isc/utils
src/lib/python/isc/utils/__init__.py
src/lib/python/isc/utils/Makefile.am
src/lib/python/isc/utils/process.py
src/lib/python/isc/utils/tests
src/lib/python/isc/utils/tests/Makefile.am
src/lib/python/isc/utils/tests/process_test.py
src/lib/testutils
src/lib/testutils/Makefile.am
src/lib/testutils/mockups.h
src/lib/testutils/README
src/lib/testutils/srv_test.h
src/lib/testutils/srv_unittest.h
src/lib/testutils/testdata
src/lib/testutils/testdata/badExampleQuery_fromWire.spec
src/lib/testutils/testdata/example.com
src/lib/testutils/testdata/examplequery_fromWire.spec
src/lib/testutils/testdata/example.sqlite3
src/lib/testutils/testdata/iqueryresponse_fromWire.spec
src/lib/testutils/testdata/Makefile.am
src/lib/testutils/testdata/multiquestion_fromWire.spec
src/lib/testutils/testdata/queryBadEDNS_fromWire.spec
src/lib/testutils/testdata/shortanswer_fromWire.spec
src/lib/testutils/testdata/shortmessage_fromWire
src/lib/testutils/testdata/shortquestion_fromWire
src/lib/testutils/testdata/shortresponse_fromWire
src/lib/testutils/testdata/simplequery_fromWire.spec
src/lib/testutils/testdata/simpleresponse_fromWire.spec