[bind10-dev] new trunk in subversion and review procedure

Jeremy C. Reed jreed at isc.org
Fri Feb 5 18:26:48 UTC 2010


We have a code review procedure as documented at 
http://bind10.isc.org/wiki/CodeReviewProcedure

But with our manager's permission, we decided on our call yesterday to 
"bootstrap" our trunk by getting our existing parkinglot in it.

We will need to do a review of all code now in the trunk.

And we must follow our policy that from now on all new code committed to 
the trunk must follow the code review procedure.

I will open new tickets for the reviews needed now to make sure the 
trunk has been reviewed. Any code (in trunk now as of revision 738) that 
does not get reviewed will be removed from the trunk before we ship.

-=-=-=-=-=-=-=-
Reviews needed:
-=-=-=-=-=-=-=-

- configure.ac, Makefile.am and related for main level
http://bind10.isc.org/ticket/35

- src/bin/auth
http://bind10.isc.org/ticket/36

- src/bin/bindctl
http://bind10.isc.org/ticket/37

- src/bin/cfgmgr
http://bind10.isc.org/ticket/38

- src/bin/cmdctl
http://bind10.isc.org/ticket/39

- src/bin/msgq
- src/lib/cc/cpp
- src/lib/cc/python
These are reviewed together? Also a review was done, so double-check if
anything was changed since last review and parkinglot revision 736.
http://bind10.isc.org/ticket/22

- src/bin/bind10
http://bind10.isc.org/ticket/40

- src/bin/stats
http://bind10.isc.org/ticket/41

- src/lib/auth/cpp
http://bind10.isc.org/ticket/42

- src/lib/config/cpp
- src/lib/config/python
http://bind10.isc.org/ticket/43

- src/lib/dns/cpp
Some of this was already reviewed. Either review all again or find out 
what versions were reviewed up to and review new.
http://bind10.isc.org/ticket/44

- src/lib/exceptions
http://bind10.isc.org/ticket/45

NOTE: if multiple reviews are required, please make a note of that in 
the related ticket and create additional new ticket(s) as needed.

Existing reviews include:

- review element class
http://bind10.isc.org/ticket/20

- MsgQ review
http://bind10.isc.org/ticket/22

- Python ccmsg stuff review
http://bind10.isc.org/ticket/23

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
To remove or move (away from trunk):
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

- src/lib/cc/ruby
Where to move this?

- src/bin/host
This is not complete, so maybe will move to own branch for development 
work.

- src/bin/parkinglot
Remove since is in parkinglot branch?

Please confirm the "to remove" list and we will remove from trunk.




More information about the bind10-dev mailing list