[bind10-dev] [svn] commit: r1108 - in /branches/each-nsec3/src/lib/dns/cpp: Makefile.am base32.cc base32.h sha1.cc sha1.h tests/Makefile.am tests/base32_unittest.cc tests/sha1_unittest.cc

[Evan Hunt]

> I noticed that the original copyright and license and attribution for 
> the sha1 code was missing. I was going to ask you to re-add it (plus 
> maybe comment on what you changed). For the sha1, I see several sections 
> of code and comments/documentation are near verbatim to the original 
> code (other than formatting, few type changes, and a few functions or 
> variables renamed).

All the modifications were just to match BIND10 coding style guidelines;
there were no functional changes that I can recall.

> But, the code the sha1 is based on is not open source -- well at least 
> the license is unclear. It does not say we have the right to modify nor 
> distribute the modified code.

RFC 5378, Section 5.3:

  To the extent that a Contribution or any portion thereof is protected
  by copyright or other rights of authorship, the Contributor and each
  named co-Contributor grant a perpetual, irrevocable, non-exclusive,
  royalty-free, world-wide, sublicensable right and license to the IETF
  Trust under all such copyrights and other rights in the Contribution:
   [...]
   c. to modify or prepare derivative works (in addition to
      translations) that are based on or incorporate all or part of the
      Contribution, and to copy, publish, display, and distribute such
      derivative works, or portions thereof unless explicitly disallowed
      in the notices contained in a Contribution (in the form specified
      by the Legend Instructions)

                                        eh