[bind10-dev] [svn] commit: r1108 - in /branches/each-nsec3/src/lib/dns/cpp: Makefile.am base32.cc base32.h sha1.cc sha1.h tests/Makefile.am tests/base32_unittest.cc tests/sha1_unittest.cc

[JINMEI Tatuya / 神明達哉]

At Thu, 4 Mar 2010 17:05:49 +0000,
Evan Hunt <each at isc.org> wrote:
> 
> > I don't know the copied SHA1 code is explicitly covered by the latest
> > version of RFC, but if not, I suggest we take a safer approach, e.g.
> > reuse BIND9's lib/isc/sha1.c for this short term purpose.
> 
> I looked at the BIND9 version and concluded that it would take me a couple
> of hours to pick through all the #ifdefs and be sure I'd gotten it right.
> I don't a couple of hours; I have to finish NSEC3 by Monday.
> 
> At the risk of sounding testy, can we please have this conversation
> *later*?

(I'm assuming the imported code isn't covered by the safe version of
RFC)

I'm okay with deferring it unless the unsafe code is incorporated in
the release version.  After all, it's been imported to the public
repository once, so when we remove it doesn't matter much.

I'm more concerned about overall code quality; the fact that you (and
we all) are rushing seems to indicate we end up having pretty immature
code that can't easily be reviewed and corrected after the feature
freeze point.  But you probably disagree with this view, so, go
ahead.  As long as we reserve the option of dropping "working" code if
it turns out to be immature at the review phase, I'm fine.

---
JINMEI, Tatuya