[bind10-dev] position of opening curly brace for methods

[Shane Kerr]

Jinmei,

On Thu, 2010-03-04 at 11:24 -0800, JINMEI Tatuya / 神明達哉 wrote:
> I didn't notice the following change was incorporated to the coding
> guideline page:
> 
> http://bind10.isc.org/wiki/CodingGuidelines?action=diff&version=12&old_version=11
> 
> This means we use BIND9's style regarding the position of the opening
> curly brace.  According to the change date it seems to be on the week
> of the October f2f meeting.  Was that something we agreed at that
> time?
> 
> I've been thinking we decided to drop the BIND9 style on this point,
> so I've coded things that way.  I'm totally fine with the agreed style
> and don't mind changing already written code, but I'd like to be sure
> that this is the style that was agreed on (because I didn't remember
> it).
> 
> I'd appreciate it if someone could confirm the decision.
> 
> (To be very clear, I'm not challenging it.  I just want to get
> confirmation)

Just so I'm clear, what does it mean to drop the BIND 9 style? Do you
mean that we always put the open curly brace on a line by itself for a
function declaration:

void
bind9_looks_like_this(int foo) {
}

void
bind10_looks_like_this(int bar)
{
}

I really don't remember a decision about this, but it is quite possible
one was made. Hopefully someone else has a clearer memory....

--
Shane

p.s. My own personal preference is to always put the opening curly brace
on a line by itself, but I've worked with BIND 9 enough that the old
style doesn't hurt my eyes too much. :)