[bind10-dev] -Wall

[Jeremy C. Reed]

On Wed, 10 Mar 2010, Shane Kerr wrote:

> I saw this change:
> 
> http://bind10.isc.org/changeset/1256
> 
> And I was thinking, at least we should keep -Wall, even if we don't
> promote warnings to errors. Eventually we need to find and fix these...

Yes, I agree it should have -Wall. Note that this change just removed it 
from two specific places and none of the others had it in their own 
makefiles.

t1:trunk$ grep Wall src/lib/*/Makefile.am                                      
t1:trunk$ grep Wall src/bin/*/Makefile.am 
t1:trunk$ 

Nevertheless it should still be there for gcc for everything via 
configure:

# default compiler warning settings
if test "X$GCC" = "Xyes"; then
CXXFLAGS="$CXXFLAGS -g -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare"
fi

It appears to be using it:
http://bind10.isc.org/~tester/builder/BIND10/20100310124001-Debian5Linux-i686/logs/build.out