[bind10-dev] libdns and problem record and loadzone loading it

[JINMEI Tatuya / 神明達哉]

At Thu, 11 Mar 2010 03:28:28 +0000,
Evan Hunt <each at isc.org> wrote:

> > What should libdns do? I don't think b10-auth should crash due to 
> > accidently loaded data in the data source. Shouldn't return some FORMERR 
> > or SERVFAIL other problem?
> 
> SERVFAIL seems appropriate.

Yes, but please don't do catch (...).  We should selectively catch
internal errors.  I'll do that.

> This does the job, but should probably do more; if any data has been added
> to the message sections before the exception was encountered, it should be
> cleared.  I don't see an easy way to do that with the current Message API
> however.

Clear it first, and re-construct the error message from the scratch.
I'll also take care of it as part of the auth server cleanup I'm
currently doing.

BTW, I personally think we're giving too much responsibility to the
data source module by having it construct response messages.  IMO
the data source modules should focus on the lookup service and should
be free from other DNS related details.  (Likewise, IMO we should pass
the specific lookup key (that would probably be a tuple of
qname/qclass/qtype) to the data source module rather than passing the
entire query message and having the module to extract the lookup key
from the Question section).

Whether or not it's a compelling argument, however, I understand it's
certainly a post-year1 fodder.

---
JINMEI, Tatuya