[bind10-dev] BIND bindctl review && bindctl certificate

[zhanglikun]

>  bindctl-source.py:
> 
>  __version__ shouldn't that be a number? (or possibly even set from
>  configure)
>  bindcmd.py:
> 
>  help also shows a version hardcoded in the string that should come from
>  configure

Yes, it should get the version number from configure file. (Add to TODO list)
BTW, if the version number of all modules of bind10 should be same?


>  What does CONST_COMMAND_NODE do?
I will remove it, it's a variable that had been used.

> 
>  Do we really need a client-side PEM certificate? (which isn't read from
>  the right location right now, i think this should have to be either
>  <install-prefix>/etc/bind10/ or /var/bind10, and from source tree
>  if run from source)
Client-side PEM certificate is not absolutely necessary, since it can be asked from server-side (cmdctl), then save the certificate in location.
But now, cmdctl doesn't support certificate request from client,  because,

1. cmdctl is not the server that provides public service, it's the entry of the commands to bind10. So if any client wants to control bind10, it should get the certificate first from the admin of bind10, if not, any one can the certificate freely.
2. the example certificate in cmdctl is self-signed, and I don't think the user of bind10 in future will like buy some certificate from certificate authority(maybe not).

>  If we have a default user, we also provide a way to override that,
>  also storing the password plaintext might not be a great idea :)
Yes, I will add it to TODO.

>  SSL error needs to be something understandable (this is in TODO
>  already)
> 
>  We need to think of what exactly to do with responses received to
>  commands (currently it simply prints the map)
Yes, I will add this one to TODO.

Thanks