[bind10-dev] FYI: Backdating in trunk?

[Naoki Kambe]

This is FYI.

In bind10.py.in of trunk, line:463 was added in r3218, and then line:
457-462 was modified in r3273. But line:463 wasn't modified. I think
we might backdate between r3240 and r3273.

So now Stats doesn't shutdown properly by Boss and it is killed by
SIGTERM by Boss. We will fix this in ticket #347 too. This is a small
problem but I think we should be careful before merging with trunk.

http://bind10.isc.org/changeset?new=3273%40trunk%2Fsrc%2Fbin%2Fbind10%2Fbind10.py.in&old=3240%40trunk%2Fsrc%2Fbin%2Fbind10%2Fbind10.py.in

svn diff -r3240:3273  bind10.py.in
Index: bind10.py.in
===================================================================
--- bind10.py.in        (revision 3240)
+++ bind10.py.in        (revision 3273)
@@ -454,12 +454,12 @@
     def stop_all_processes(self):
         """Stop all processes."""
         cmd = { "command": ['shutdown']}
-        self.cc_session.group_sendmsg(cmd, 'Boss', 'Cmdctl')
-        self.cc_session.group_sendmsg(cmd, "Boss", "ConfigManager")
-        self.cc_session.group_sendmsg(cmd, "Boss", "Auth")
-        self.cc_session.group_sendmsg(cmd, "Boss", "Xfrout")
-        self.cc_session.group_sendmsg(cmd, "Boss", "Xfrin")
-        self.cc_session.group_sendmsg(cmd, "Boss", "Zonemgr")
+        self.cc_session.group_sendmsg(cmd, 'Cmdctl', 'Cmdctl')
+        self.cc_session.group_sendmsg(cmd, "ConfigManager", "ConfigManager")
+        self.cc_session.group_sendmsg(cmd, "Auth", "Auth")
+        self.cc_session.group_sendmsg(cmd, "Xfrout", "Xfrout")
+        self.cc_session.group_sendmsg(cmd, "Xfrin", "Xfrin")
+        self.cc_session.group_sendmsg(cmd, "Zonemgr", "Zonemgr")
         self.cc_session.group_sendmsg(cmd, "Boss", "Stats")

     def stop_process(self, process):

Naoki Kambe