[bind10-dev] [svn] commit: r3558 - /experiments/kambe-auth-stats/src/bin/auth/asio_link.cc

[Michal 'vorner' Vaner]

Hello

On Thu, Nov 18, 2010 at 05:48:59AM -0000, BIND 10 source code commits wrote:
> Author: naokikambe
> Date: Thu Nov 18 05:48:59 2010
> New Revision: 3558
> 
> Log:
> disable twice exception throwing
> 
> Modified:
>     experiments/kambe-auth-stats/src/bin/auth/asio_link.cc
> 
> Modified: experiments/kambe-auth-stats/src/bin/auth/asio_link.cc
> ==============================================================================
> --- experiments/kambe-auth-stats/src/bin/auth/asio_link.cc (original)
> +++ experiments/kambe-auth-stats/src/bin/auth/asio_link.cc Thu Nov 18 05:48:59 2010
> @@ -677,8 +677,8 @@
>                              impl_, asio::placeholders::error));
>          }
>      } catch (const asio::system_error& err) {
> -        isc_throw(IOError, "Failed to start deadline_timer: " <<
> -                  err.what());
> +        cerr << "[b10-auth] Failed to start deadline_timer: "
> +             << err.what() << endl;
>      }
>      impl_->io_service_.run();
>  }

Just curious, what was wrong with the old code? It looked ok, just translating
one exception to another, while the new code logs and swallows the exception. It
is your code and I expect you know why you do it, it just isn't clear to me why
anyone would want to do that.

Thanks

-- 
Wait few minutes before opening this email. The temperature difference 
could lead to vapour condensation.

Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20101118/3ed91d67/attachment.bin>