[bind10-dev] ccsession api

Jelte Jansen jelte at isc.org
Mon Oct 4 12:22:07 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/26/2010 05:26 PM, Michal 'vorner' Vaner wrote:
> 
> What I do not like is, the blocking/nonblock are negated against each other.
> Some code acts as it is the nonblock, some looks like it expects the blocking
> (passes False and expects to get None, None ‒ which you never get with blocking
> read).
> 

the variable name in the fake session should be nonblock; at least, that's what
the real API defines it as. The name 'blocking' probably snuck in because that
seems to make more sense to me :p

If you're hitting that code my suggestion is to replace it while you're at it.
If not I can make the change in trunk (renaming an unused variable in a piece of
test code doesn't really need a ticket imo)

Jelte
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkypxu8ACgkQ4nZCKsdOncX+8ACguudufyM9WgOPTGk0rz+x7ao3
Y+UAnRH4tTAvbNayWEYAUGD2YigmdCEV
=QXCf
-----END PGP SIGNATURE-----



More information about the bind10-dev mailing list