[bind10-dev] Precommit hook blocks third-party code

[JINMEI Tatuya / 神明達哉]

At Mon, 20 Sep 2010 16:13:13 +0200,
Michal 'vorner' Vaner <vorner at ucw.cz> wrote:

> I'm trying to bundle the setproctitle library so it can be installed
> if needed.  However, the code contains tabs and the SVN server does
> not like it:
> 
> A repository hook failed: Commit blocked by pre-commit hook (exit
> code 1) with output:
> The following files contain tabs:
> branches/trac322/ext/setproctitle/setproctitle-1.1/src/c.h
> 
> What is the correct way here? Should I modify the third-party code
> in ext so it does not contain the tabs, the hook should be modified
> to be less prudent on ext or someone is able to force it?

Personally, I don't like to have our local copy of third party
libraries in our repository.  I'd consider ASIO a very special case,
and I still think there's a better way even for ASIO than having an
unpacked copy of it in the repository.  This is probably a good timing
to explore alternative (and IMO cleaner) approaches.

Some possibilities:
- have the library source in the form of an archive, and unpack it at
  build time
- automatically download a tar ball at build time
- assuming this is not an absolutely mandatory feature, make it
  optional and use it only when already installed (with some
  appropriate wrapper layer).  With this approach it's the user's
  responsibility to install the library.

---
JINMEI, Tatuya
Internet Systems Consortium, Inc.