[bind10-dev] BIND 10 master, updated. da32354d05eb22cecdf9543f542636d44e503a20 [master] commit ChangeLog entry for #1128

[JINMEI Tatuya / 神明達哉]

At Wed,  3 Aug 2011 05:28:19 +0000 (UTC),
BIND 10 source code commits <bind10-changes at lists.isc.org> wrote:

> - Log -----------------------------------------------------------------
> commit da32354d05eb22cecdf9543f542636d44e503a20
> Author: chenzhengzhang <jerry.zzpku at gmail.com>
> Date:   Wed Aug 3 13:27:30 2011 +0800
> 
>     [master] commit ChangeLog entry for #1128

> +277.	[func]		jerry
> +	Implement the SRV rrtype according to RFC2782.
> +	(Trac #1128, git 5fd94aa027828c50e63ae1073d9d6708e0a9c223)
> +

I believe ChangeLog entry should also be reviewed (at least #1128
doesn't contain the proposed entry).  Sometimes we tend to write
not-so-useful entries.  By explicitly getting a second eye on them we
can reduce the risk.

(BTW this is noted in the "official" review process at
http://bind10.isc.org/wiki/CodeReviewProcedure but as I noted in
today's sprint meeting no one actually reads/remembers it:-)

Or, if it was actually reviewed on jabber or via some other non
obvious communication channel, at least the commit log should note
that (and ideally it should be recorded in the ticket, too).

---
JINMEI, Tatuya