[bind10-dev] Tool to audit parameters of messages?

[Shane Kerr]

Jinmei,

On Tue, 2011-12-06 at 11:32 -0800, JINMEI Tatuya / 神明達哉 wrote:
> At Tue, 06 Dec 2011 13:45:38 +0100,

> > I submitted the attached bug report yesterday, and I was thinking, do we
> > need a tool to check for such mismatched parameters?
> > 
> > LIBXFRIN_DIFFERENT_TTL multiple data with different TTLs (600, 3600) on %3/%4. Adjusting 3600 -> 600.
> > 
> > Clearly we're missing %3 and %4 on our invocation.
> > 
> > Apologies if this is already in a separate ticket that we have about
> > care and feeding of our log messages!
> 
> I think #1055 was intended to cover this topic.

Ah, yes, I see it is included there.

> We might also perform quick check in a buildbot like this:
> % B10_LOGGER_DESTINATION=stdout make check |& grep '^[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9]'|grep '%'
> 2011-12-06 11:27:04.231 INFO  [bind10.test] LOG_INPUT_OPEN_FAIL unable to open message file %1 for input: %2
> 2011-12-06 11:28:05.972 INFO  [bind10.boss] BIND10_SOCKET_GET requesting socket [%1]:%2 of type %3 from the creator
> 
> (The output is expected to be empty, so if it's not it will be
> reported as failure)
> 
> Hmm, the fact this quick check couldn't find your example case would
> also mean we don't have a sufficient number of tests:-)

Hm... I think perhaps comparing our number of unique log identifiers
with the number we produce from our tests may also be an interesting
measure of coverage...

--
Shane