[bind10-dev] The small matter of a trailing "_"

[Scott Mann]

Hello,

I ran across trailing underscores on some variables in the bind 10 code 
base, for instance:

shared_ptr<AddressVector> upstream_;

At first, I thought that the convention had something to do with shared 
pointers, but further examination suggested that it was used for data 
class members (which is in the google 
<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variable_Names#Variable_Names> 
standard linked at our CodingGuidelines 
<http://bind10.isc.org/wiki/CodingGuidelines> wiki page). I asked about 
this on jabber and Stephen replied that indeed the trailing underscore 
was used for data class members. But Jinmei pointed out that there 
really wasn't a consensus around this.

Well, between Stephen's and Jinmei's comments, I edited the 
CodingGuidelines wiki page to include: "Data class members are like_this_".

Do we need to discuss this? Or is this usage acceptable? Easy enough to 
redact the change :~)

-Scott