[bind10-dev] XfrOut questions

[Michal 'vorner' Vaner]

Hello

On Tue, Jul 12, 2011 at 09:38:35AM +0800, Likun Zhang wrote:
> > One of them is, every time I want to modify it, it takes quite a lot of time to get
> > trough it to find out where. I don't know why, maybe just the C++ is more strict in
> > its typing, so it is easier to follow.
> 
> >From some experience, maybe it's caused by some exception catched too generally,

Well, I see a different problem. The python code has
the same visual structure everywhere and doesn't
have strict typing in function prototypes, which
makes it harder to see the relations of parts of
code.

Another thing is, C++ has headers, so the interface
is at one place, making it shorter to read.

Yet another thing is, XfrOut is one huge file.

The thing with exceptions might be true, but is
minor.

> >       # C++ loadable module may not be installed; even so the xfrout process
> >       # must keep running, so we warn about it and move forward.
> >       log.error(XFROUT_IMPORT, str(e))
> > 
> >   This makes sure the program starts even when it can't load the DNS library.
> >   I didn't try it, but I think it will simply crash the first time any request
> >   comes, since it won't be able to parse. Or, maybe the exception will be caught
> >   and the request dropped.
> > 
> >   But, the question is, why is it so important to have the program running even
> >   when it is completely useless, instead of being a nice program and complaining
> >   loudly that the installation is corrupted?
> 
> The code was suggested at beginning, since sometime, the dns library is not installed properly, xfrout process will report import error and exit, but bind10 will always try to restart xfrout, even the user just use b10-auth process, so we ignored the import error, and make xfrout process can be started without dns library. 

And it will mask the very serious problem - the
installation is corrupted and must be fixed and that
the service is down. We might want to do something
about the periodic restarts, like give up when it
didn't start 5 times in a row or something, but I
believe it is time to remove such masking code.

With regards

-- 
Never underestimate the bandwidth of a station wagon full of HDDs.

Michal 'vorner' Vaner