[bind10-dev] redundant white spaces and colored git diff

JINMEI Tatuya / 神明達哉 jinmei at isc.org
Mon Jun 20 18:23:48 UTC 2011


In my code review I often find trivial and very minor editorial
issues: redundant white space(s) after the end of line or in a blank
line.

These are basically very minor and wouldn't be a big issue in terms of
code sharing (unlike the mixed use of inconsistent styles), but it can
be cleaned up with minimal effort and would make the code more
"professional" (by showing it's carefully written), so I think it's
worth addressing in terms of the cost-benefit balance.

Colored version of git diff is a very effective tool to identify these
editorial issues.  See, e.g.:
http://gyazo.com/bdd070d0925080fabcc279a2984080f2.png
(the red cursors indicate redundant white spaces)

So I'd suggest before anyone starts asking for code review the entire
diff is checked and redundant spaces are removed.

---
JINMEI, Tatuya



More information about the bind10-dev mailing list