[bind10-dev] Dummy DHCPv6 component review request
Tomasz Mrugalski
tomasz at isc.org
Mon Jun 20 18:24:53 UTC 2011
Couple of days ago, I wrote dummy DHCPv6 component in bind10. It does
nothing useful yet, just sits there and repeats that is is alive every
10 seconds. I also wrote 3 tests for it.
The code is on trac990 branch.
Could someone review it, please? This is my first contribution to
bind10, so I appreciate your feedback. There's not much actual code to
review, but I would love to hear your comments if the following extra
things done correctly:
- daemon naming
- git branching (there are several commits on trac990 branch. Should I
squish my commits into one before merging to master)?
- the tests are implemented correctly (and located in dirs)
- bind10.py modification is correct (nobody would benefit from dhcpv6
starting now, so it is disabled by default)
I also have couple of questions:
Are there any documents regarding test designs or test strategy? I
haven't read anything bind10 specific, just looked at existing code and
wrote something similar
I noticed that make check aborts on first failed test. Is there a way to
run the tests to continue and then present a summary (e.g. 5 out of 235
tests failed)?
I also noticed that there is no .gitignore file. After I compiled the
code, I got 100s of files that git shows. Mostly object and lib files,
but also backups (~) and many more. For now, I created such file for
src/bin/dhcp6. Would it be ok to add repo wide one as well? Should I
create ticket for it?
Tomek
More information about the bind10-dev
mailing list