[bind10-dev] BIND 10 master, updated. 376df1c9ac466742afad6681ff2e431ebfd75b63 [master] update ChangeLog for #1001

[JINMEI Tatuya / 神明達哉]

At Tue, 28 Jun 2011 02:32:46 +0000 (UTC),
BIND 10 source code commits <bind10-changes at lists.isc.org> wrote:

> diff --git a/ChangeLog b/ChangeLog
> index c1ff9d0..37bb9bd 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +264.	[bug]       jerry
> +	Fix a busy loop issue in notify-out.
> +	(Trac 1001, git fb993ba8c52dca4a3a261e319ed095e5af8db15a)
> +

I'm afraid this changelog entry is not sufficiently helpful.

It doesn't explain which module (program) caused the loop, how severe
it is (whether it could occupy 100% of CPU cycle or it's milder than
that), whether the problem (can) happen regularly or only in a rare,
limited situation, etc.

I'd revise it to something like this:

	b10-xfrout: fixed a busy loop in its notify-out subthread.  Due to
	the loop, the thread previously woke up every 0.5 seconds throughout
	most of the lifetime of b10-xfrout, wasting the corresponding CPU
	time.

Ticket #1001 doesn't have a discussion about the changelog.  Was it
included in the branch and got reviewed?  If so, we should blame the
reviewer:-)  If not, please make sure changelog entries get reviewed as
well the code (this is also documented in the code review procedure at
http://bind10.isc.org/wiki/CodeReviewProcedure although some part of
seem to be already outdated and many of us don't actually refer to it
anyway).

---
JINMEI, Tatuya