[bind10-dev] [sprint planning] estimate results 20111206

[Michal 'vorner' Vaner]

Hello

On Mon, Nov 28, 2011 at 12:14:17PM -0800, JINMEI Tatuya / 神明達哉 wrote:
> > It is. However, I think that the current code is relatively easy to read. Maybe
> > just if we had a specific variable saying which type of stream it is. But having
> > a subclass for each type of scream means we will have the iteration through the
> > stream many times and they are mostly identical (as there's already a
> > polymorphism on the datasrc level) and there are only slight exceptions, like
> > the SOA handling. I believe introducing another level of indirection just
> > increases the size of code and makes it harder to grasp what is happening in
> > this case.
> 
> I personally believe that the current style of if-else analysis tends
> to cause subtle bugs in boundary conditions and still personally
> believe it's worth generalizing.  But at the same time I admit that
> this may be a matter of preference and that the current code is not
> particularly unreadable.  So, in the sense of avoiding
> over/premature-generalization I'm okay with not doing this task.

OK, so let's wait until we find a bug there and see if it would be better fixed
if it was split into classes. If so, then can we refactor it as part of the fix?

> At the very least, the traceback isn't helpful as a hint to solve the
> problem (*I* know many details of the BIND 10 system and could figure
> what was missing from the output, but *they* wouldn't).
> 
> So I'd keep this ticket as a task to find a reasonable middleground.

Would a correct exception and description be the middleground or do we need
something else?

Thanks

With regards

-- 
BOFH Excuse #452:
Somebody ran the operating system through a spelling checker.

Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20111129/f9d88fcd/attachment.bin>