[bind10-dev] in order to build bind10-20120517 against log4cplus-1.1.0-rc5

[John Lumby]

After applying the patch that Václav Zeman from log4cplus sent me (this time against log4cplus-1.1.0-rc7),
I built bind10-devel-20120621against that patched log4cplus and it does appear to fix the original build problem.

I still had two very minor build problems in bind10 -  missing log4cplus #includes  -   which I patched as below.

Soo  ...   Jeremy,  if you would please try applying my patch below to your bind10 and then build against your log4cplus-1.0.x,
and if that builds cleanly,  then I'd say that the below patch lets bind10 build cleanly on log4cplus-1.0.x and also extremely recent (or patched) log4cplus-1.1.x.


bind10-devel-20120621_on_log4cplus-1.1.0-rc7.120802-131056.patch :
#######################################################################
--- src/lib/log/logger_manager_impl.cc.orig	2012-03-23 09:31:57.000000000 -0400
+++ src/lib/log/logger_manager_impl.cc	2012-08-02 12:26:33.644361171 -0400
@@ -17,6 +17,7 @@
 
 #include <log4cplus/logger.h>
 #include <log4cplus/configurator.h>
+#include <log4cplus/hierarchy.h>
 #include <log4cplus/consoleappender.h>
 #include <log4cplus/fileappender.h>
 #include <log4cplus/syslogappender.h>
--- src/lib/log/logger_impl.cc.orig	2012-06-06 10:41:57.000000000 -0400
+++ src/lib/log/logger_impl.cc	2012-08-02 12:15:50.060345875 -0400
@@ -21,7 +21,9 @@
 #include <boost/lexical_cast.hpp>
 #include <boost/static_assert.hpp>
 
+#include <log4cplus/logger.h>
 #include <log4cplus/configurator.h>
+#include <log4cplus/loggingmacros.h>
 
 #include <log/logger.h>
 #include <log/logger_impl.h>
#######################################################################


John Lumby
Database Architect
BlueCat Networks Inc.

________________________________________
From: Jeremy C. Reed [jreed at isc.org]
Sent: Wednesday, August 01, 2012 6:51 PM
To: John Lumby
Cc: bind10-dev at lists.isc.org
Subject: RE: [bind10-dev] in order to build bind10-20120517 against log4cplus-1.1.0-rc5

On Wed, 1 Aug 2012, John Lumby wrote:

> I also appended the log4cplus-dev today before noticing your append :-)

Thank you for sending that email.

> Does bind10 need to be able to build against log4cplus-1.0.x?

Yes. It may be over six months before newer log4cplus (which is not
official released yet) is available in various package systems. In
addition, I don't want to upgrade it on my 15 systems :)