[bind10-dev] Minor changes to coding style guidelines

[Shane Kerr]

Francis,

On Monday, 2012-02-06 15:45:07 +0000, 
Francis Dupont <fdupont at isc.org> wrote:
> > 1. We now specify the order of headers
> >    http://bind10.isc.org/wiki/CodingGuidelines#OrderingIncludeFiles
> 
> => IMHO we should add a line explaining config.h goes first when
> it is present (BTW this follows the rules but not in an obvious way)

Since this is how autoconf is supposed to be used, that makes sense.

> > 2. The style for catch statements is now documented
> >    http://bind10.isc.org/wiki/CodingGuidelines#CurlyBracesforCatch
> 
> => as it is a common source of spurious warnings, I add like to get
> a statement explaining the variable ("ex" in the wiki) should be
> present only when used in the exception body.

This also makes sense.

> PS: when these new rules will be applied to all source files?
> (i.e., I prefer to synchronize my git repo after in the case I get
> free time to update (and clean up) the Windows support).

Others may disagree, and I am open for discussion, but I think that
these new rules will probably never be applied to all source files. I
have no intention of asking the team to go through all of the source
looking for violations of our coding guidelines! Even applying an
automated code formatting tool seems like a big waste of time to me.

--
Shane