[bind10-dev] EXPECT_TRUE() considered harmful?

JINMEI Tatuya / 神明達哉 jinmei at isc.org
Tue Feb 21 07:10:39 UTC 2012


At Mon, 20 Feb 2012 16:54:53 +0100,
Shane Kerr <shane at isc.org> wrote:

> While looking through old tickets, I found this:
> 
> http://bind10.isc.org/ticket/398

[...]

> I propose that we add this recommendation to the coding guidelines:
> 
> http://bind10.isc.org/wiki/CodingGuidelines

As the reporter of the ticket I support the proposal.  One note: there
are cases we cannot use EXPECT_<op> because sometimes the class of
the compared objects do not meet template requirements (most commonly
observed failure case is it doesn't have corresponding operator<<).

Obviously, in such cases EXPECT_TRUE/FALSE should be allowed as a
compromise.

---
JINMEI, Tatuya


More information about the bind10-dev mailing list