[bind10-dev] EXPECT_TRUE() considered harmful?

Shane Kerr shane at isc.org
Wed Feb 22 10:36:40 UTC 2012


All,

On Monday, 2012-02-20 16:54:53 +0100, 
Shane Kerr <shane at isc.org> wrote:
> The ticket says:
> 
> 	In general, when we do
> 
> 	    EXPECT_TRUE(a <op> b);
> 
> 	it's better to be changed to:
> 
> 	    EXPECT_<op>(a, b);
> 
> 	because when the test fails the latter will provide more
> 	detailed information (the values of a and b).


> I propose that we add this recommendation to the coding guidelines:
> 
> http://bind10.isc.org/wiki/CodingGuidelines

Okay I've updated the guidelines, adding this recommendation.

Also, I changed the examples to use Trac syntax highlighting. Hopefully
that is more helpful than distracting.

Cheers,

--
Shane


More information about the bind10-dev mailing list