[bind10-dev] BIND 10 trac826, updated. 71ae6fae84ff35239024b745aec812b679183964 fix the lib dns++ message rendering benchmark

[Francis Dupont]

> Hmm, why didn't the original version (of yours) work?

=> the _WIN32 ifdef is too late and the bench/benchmark.h include
fails on timeval... It will be in the next pushed commit.

> Listing
> standard/vendor header files below ours is in our style policy, so if
> this is an inevitable exception I think we should note that in our
> guideline page (even if the Windows support is currently very
> experimental).

=> perhaps the right way should be to include networking stuff
(mswsock, winsock2, ws2tcpip, etc) in config.h but I am afraid
it will be very expensive. And it increases the probability of
name collisions (IN for instance)...

> At Fri, 29 Jun 2012 14:50:50 +0000,
> BIND 10 source code commits <bind10-changes at lists.isc.org> wrote:
> > -----------------------------------------------------------------------
> > diff --git a/src/lib/dns/benchmarks/message_renderer_bench.cc b/src/lib/dns
> /benchmarks/message_renderer_bench.cc
> > index 63c2a35..1ba61df 100644
> > --- a/src/lib/dns/benchmarks/message_renderer_bench.cc
> > +++ b/src/lib/dns/benchmarks/message_renderer_bench.cc
> > @@ -14,17 +14,17 @@
> >  
> >  #include <config.h>
> >  
> > +#ifdef _WIN32
> > +#include <getopt.h>
> > +#include <winsock2.h>
> > +#endif
> > +
> >  #include <bench/benchmark.h>
> >  
> >  #include <dns/name.h>
> >  #include <dns/messagerenderer.h>
> >  #include <oldmessagerenderer.h>
> >  
> > -#ifdef _WIN32
> > -#include <getopt.h>
> -#include <winsock2.h>
> > -#endif
> > -
> >  #include <cassert>
> >  #include <vector>

Thanks

Francis Dupont <fdupont at isc.org>