[bind10-dev] failed build

[JINMEI Tatuya / 神明達哉]

At Tue, 13 Mar 2012 22:15:01 +0000 (UTC),
tester at isc.org (BIND 10 Tests) wrote:
> 
> http://git.bind10.isc.org/~tester/builder//BIND10/20120313220000-FreeBSD8-i386-Clang/logs/build.out
> 
> http://git.bind10.isc.org/~tester/builder//builder.html

The patch below should fix this failure.  Could someone git it an OK?

---
JINMEI, Tatuya

diff --git a/src/lib/datasrc/memory_datasrc.cc b/src/lib/datasrc/memory_datasrc.cc
index 477baa5..eb6e2c5 100644
--- a/src/lib/datasrc/memory_datasrc.cc
+++ b/src/lib/datasrc/memory_datasrc.cc
@@ -1315,12 +1315,12 @@ getAdditionalName(RRType rrtype, const rdata::Rdata& rdata) {
     if (rrtype == RRType::NS()) {
         const generic::NS& ns = dynamic_cast<const generic::NS&>(rdata);
         return (ns.getNSName());
-    } else if (rrtype == RRType::MX()) {
+    } else {
+        // In our usage the only other possible case is MX.
+        assert(rrtype == RRType::MX());
         const generic::MX& mx = dynamic_cast<const generic::MX&>(rdata);
         return (mx.getMXName());
     }
-    // In our usage this shouldn't happen.
-    assert(false);
 }
 
 bool