[bind10-dev] code review style

[Kevin Tse]

Dear all,

	I have encountered a problem how we do code review, and I think there
may be some thing changed for our code review style. Because some times
the code review made me confused.There may be an Explicit style
documentation for it like code style documentation.

I read an article
"http://scientopia.org/blogs/goodmath/2011/07/06/things-everyone-should-do-code-review/"
by a former employee of Google one year ago.

In this article,there is lot of principle and pos and cons for code
review and I think it do help for code review.Such as:
"
The most common mistake in code review - the mistake that everyone makes
when they're new to it - is judging code by whether it's what the
reviewer would have written.
Given a problem, there are usually a dozen different ways to solve it.
Andgiven a solution, there's a million ways to render it as code. As a
reviewer, your job isn't to make sure that the code is what you would
have written - because it won't be. Your job as a reviewer of a piece of
code is to make sure that the code as written by its author is correct.
When this rule gets broken, you end up with hard feelings and
frustration all around - which isn't a good thing.
"

With Regards,
-- 
Kevin Tse <xiejiagui at cnnic.cn>
CNNIC

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 316 bytes
Desc: This is a digitally signed message part
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20120514/a4254612/attachment.bin>