[bind10-dev] BIND 10 trac1954, updated. d6f64f5a6b1c524e6b6fd91151df7dee98add719 [1954] Switching to fully compile with C++ to get rid of clang linking errors

[JINMEI Tatuya / 神明達哉]

At Mon, 21 May 2012 18:28:54 +0000 (UTC),
BIND 10 source code commits <bind10-changes at lists.isc.org> wrote:

>        via  d6f64f5a6b1c524e6b6fd91151df7dee98add719 (commit)
>       from  a5171dfc73c99aaa7d8191d309d9808dca19b49b (commit)
> 
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.

> +# We have to suppress errors because we are compiling C code with CXX
> +# We have to do this to link with new C++ pieces of code
> +perfdhcp_CXXFLAGS = $(AM_CXXFLAGS)
> +perfdhcp_CXXFLAGS += -Wno-error -Wno-writestrings

Shouldn't we do this at least selectively, only when it's absolutely
necessary?  From a quick look at the commit log, this was needed
because
- when you use clang you need to use it as a C++ compiler for some
  linker issue
- C++ compilers generally complain about plain-old C code a lot, and
  -Werror breaks the build

So, for example, I guess we could

- use C++ compiler only when you use clang
- specify -Wno-error only for that environment

It's ultimately your call, but I personally think disabling -Werror
unconditionally is very dangerous, and will eventually bite
yourself...

---
JINMEI, Tatuya