[bind10-dev] BIND 10 trac1954, updated. d6f64f5a6b1c524e6b6fd91151df7dee98add719 [1954] Switching to fully compile with C++ to get rid of clang linking errors

[Marcin Siodelski]

On 05/22/2012 09:09 AM, JINMEI Tatuya / 神明達哉 wrote:
> At Mon, 21 May 2012 22:00:05 +0300,
> Tomek Mrugalski <tomasz at isc.org> wrote:
> 
>>>> +# We have to suppress errors because we are compiling C code with CXX
>>>> +# We have to do this to link with new C++ pieces of code
>>>> +perfdhcp_CXXFLAGS = $(AM_CXXFLAGS)
>>>> +perfdhcp_CXXFLAGS += -Wno-error -Wno-writestrings
>>>
>>> Shouldn't we do this at least selectively, only when it's absolutely
>>> necessary?  From a quick look at the commit log, this was needed
>>> because
>> Marcin is gradually refactoring existing C code into C++. It is too
>> large for a single task. Once the code is fully refactored, -Wno-error
>> should be removed.
>>
>> The whole refactoring operation is planned for around 6 weeks.
> 
> Martin explained that to me directly, and I understood it.
> 
> I'd still suggest re-enabling -Werror as soon as possible rather than
> deferring it until the conversion is fully completed because it would
> help you in the conversion, but that's really your call.

I made a typo in options. If we do this for either clang or gcc instead:

perfdhcp_CXXFLAGS += -Wno-write-strings

and make sure there are no other warnings it should be enough. I will
check it in as a part of ticket. Thanks for your insight into this.

Marcin