[bind10-dev] BIND 10 master, updated. 39dcfd79bb1b79812838c7b2f1eb146519f9cf7e [master] Workaround for unused-variable issues on Solaris.

Marcin marcin at isc.org
Tue May 29 09:04:59 UTC 2012


On 05/29/2012 10:04 AM, Michal 'vorner' Vaner wrote:
> Good morning
>
> On Mon, May 28, 2012 at 07:28:28PM +0000, BIND 10 source code commits wrote:
>>  int
>>  main(const int argc, char* const argv[])
>>  {
>> +    // We need to manipulate argc and argv to avoid
>> +    // unused-variable warnings.
>> +    // This is temporary solution.
>> +    int ac = argc;
>> +    char* av = argv[0];
>> +    if (ac >= 0 && av != 0) {
>> +        ac = 1;
>> +    }
> I don't want to be rude, or anything, but was this reviewed anywhere? It should
> be enough to just omit the argc and argv names of parameters, so you'd have:
>
> int
> main(const int, char* const*)
>
> With regards
>

I will double check this on Solaris and change this once checked.

Marcin


More information about the bind10-dev mailing list