[bind10-dev] Minor things about the master loader

JINMEI Tatuya / 神明達哉 jinmei at isc.org
Mon Nov 5 22:20:03 UTC 2012


At Mon, 5 Nov 2012 20:06:44 +0100,
Michal 'vorner' Vaner <michal.vaner at nic.cz> wrote:

> > >  • The InputSource provides line number only. But the API design suggests we
> > >    should pass line number and byte offset in the file with errors and warnings.
> > >    Should the master loader/lexer/whatever count the bytes as it calls
> > >    inputSource.getChar() or should this function be added to the input source?
> > 
> > (in my memory) I though we'd like to have the byte count so we can
> > implement the progress bar in the loadzone-ng (we could use line
> > numbers, but to do so we need the total number of lines beforehand,
> > which is not easy to count).  For that purpose the best place to do
> > should be InputSource because that's the class that knows where
> > exactly we are in the input file (or stream).
> 
> Therefore the InputSource needs to be extended. I don't know if Mukund already
> merged it, though.

I think this should go to a separate ticket.  This feature won't be
needed until we revise b10-loadzone, and other more primitive tasks
depend on #2369.  So it's better to complete #2369 sooner.

---
JINMEI, Tatuya
Internet Systems Consortium, Inc.


More information about the bind10-dev mailing list